Re: [patch 4/4] KVM-trace port to tracepoints

From: Avi Kivity
Date: Wed Jul 23 2008 - 06:08:58 EST

Christoph Hellwig wrote:
On Wed, Jul 23, 2008 at 10:55:03AM +0200, Peter Zijlstra wrote:
Andrew raised the whole point about trace_mark() generating an
user-visible interface and thus it should be stable, and I agree with

I'm not sure why this comes up again and again, but it's utter bullshit.
trace_mark does not generate any kind of user interface, just purely
a kernel internal interface.

trace_mark() is implement kvmtrace, which is propagated to userspace. So while trace_mark() itself is not a userspace interface, one of its users is.

It's an unstable interface. But so is dmesg; that's the nature of tracing.

error compiling committee.c: too many arguments to function

To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at