Re: [git pull] x86 fixes
From: Johannes Weiner
Date: Tue Jul 22 2008 - 10:35:51 EST
Hi,
Ingo Molnar <mingo@xxxxxxx> writes:
> Linus,
>
> Please pull the latest x86 fixes git tree from:
>
> git://git.kernel.org/pub/scm/linux/kernel/git/tip/linux-2.6-tip.git x86-fixes-for-linus
>
> Thanks,
>
> Ingo
>
> ------------------>
> Jan Kratochvil (1):
> x86: fix crash due to missing debugctlmsr on AMD K6-3
>
> Jeremy Fitzhardinge (2):
> x86: rename PTE_MASK to PTE_PFN_MASK
> x86: add PTE_FLAGS_MASK
Are you serious? It goes _this_ fast? The patch came into my mbox at
8:00am this morning and you push it to Linus at 4:00pm already?
What about the inconsistency it introduces? When I look at PAGE_MASK
for example, it masks out the PAGE offset. PTE_MASK masks out PTE
specifca from a value.
Now, I assume PTE_PFN_MASK masks out the PFN. Oh, wait, it masks the
protection bits.
Why not wait a bit longer before pushing things into mainline?
Hannes
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/