Re: [PATCH] x86: fix pte_flags() to only return flags, fix lguest.

From: Jeremy Fitzhardinge
Date: Tue Jul 22 2008 - 00:51:36 EST


Stephen Rothwell wrote:
Just a small point: You don't actually need the _AC() because this is
already in a #ifndef __ASSEMBLY__ section of the file. But better safe
than sorry, I guess. :-)

It's doubly wrong anyway. The correct thing to use here would be _AT(pteval_t, 0x80....FFF), but even more correct to use PTE_MASK which is already defined to have precisely this meaning.

J
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/