Re: [Patch] um: fix a build error

From: Alan Cox
Date: Mon Jul 21 2008 - 16:53:20 EST


On Mon, 21 Jul 2008 17:54:09 +0100
WANG Cong <xiyou.wangcong@xxxxxxxxx> wrote:

>
> Fixed this build error:
>
> /home/wangcong/Projects/linux-2.6/arch/um/drivers/line.c: In function
> âline_write_interruptâ:
> /home/wangcong/Projects/linux-2.6/arch/um/drivers/line.c:366: error:
> âstruct tty_ldiscâ has no member named âwrite_wakeupâ
> /home/wangcong/Projects/linux-2.6/arch/um/drivers/line.c:367: error:
> âstruct tty_ldiscâ has no member named âwrite_wakeupâ
> make[2]: *** [arch/um/drivers/line.o] Error 1
> make[1]: *** [arch/um/drivers] Error 2
> make: *** [sub-make] Error 2
>
> Sigend-off-by: WANG Cong <wangcong@xxxxxxxxx>

NAK - drivers shouldn't be poking around in tty innards in the first
place then this wouldn't break. Use tty_wakeup(tty); insteaad

Alan
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/