Re: [PATCH] V4L: Link tuner before saa7134

[Brian Marete]

On Fri, Jul 18, 2008 at 2:51 PM, Simon Arlott <simon@xxxxxxxxxxx> wrote:
>
> On Fri, July 18, 2008 12:28, Brian Marete wrote:
>> On Jul 14, 6:00 am, hermann pitton <hermann-pit...@xxxxxxxx> wrote:
>>>
>>> #1 users can't set thetunertype anymore,
>>>    but the few cases oftunerdetection from eeprom we have should
>>>    work again for that price.
>>
>> Hello,
>>
>> Any patch yet for above issue? It seems to have made it into 2.6.26.
>>
>> I use saa7134 with everything, including the tuner modules, compiled
>> as a module. My card is detected as a flyvideo2000. The default tuner
>> for that card (#37) allows me to tune into TV but not to FM Radio. I
>> can access both functions (TV and FM Radio) if I override with
>> tuner=69, which is what I usually do. That override does not work on
>> 2.6.26.
>>
>> Any suggestions?
>
> Modify saa7134_board_init2 so that the manual tuner type setting isn't
> ignored. The first thing it does is to overwrite the current value
> (set earlier from module parameter) with the static values... even
> before trying to autodetect it.
>
> In saa7134-core.c saa7134_initdev:
>  dev->tuner_type   = saa7134_boards[dev->board].tuner_type;
> +dev->tuner_addr   = saa7134_boards[dev->board].tuner_addr;
>
> In saa7134-cards.c saa7134_board_init2:
> -dev->tuner_type   = saa7134_boards[dev->board].tuner_type;
> -dev->tuner_addr   = saa7134_boards[dev->board].tuner_addr;
>
> I think that will fix it.

And, indeed, it fixed it. I hope the patch will make it into the main-line.

Thanks.

-- 
B. Gitonga Marete
Tel: +254-722-151-590
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/