Re: [PATCH 2/8] slub: Replace ctor field with ops field in/sys/slab/*

[Pekka Enberg]

Hi,

Pekka J Enberg <penberg@xxxxxxxxxxxxxx> writes:
> > +	if (s->ctor) {
> > +		x += sprintf(buf + x, "ctor : ");
> > +		x += sprint_symbol(buf + x, (unsigned long)s->ctor);
> > +		x += sprintf(buf + x, "\n");

ïOn Sun, 2008-07-20 at 02:44 +0900, OGAWA Hirofumi wrote:
> How about new "%pS" like following for it? If CONFIG_KALLSYMS=n, it has
> difference though...
> 
> 		x += sprintf(buf + x, "ctor : %pS\n", (unsigned long)s->ctor);

Looks good to me. I'd prefer to wait until this patchset is merged and
do all of mm/slub.c in one go.

		Pekka

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/