Re: [PATCH] toshiba_acpi: Add support for bluetooth togglingthrough rfkill

From: Henrique de Moraes Holschuh
Date: Sun Jul 20 2008 - 09:52:58 EST

On Sat, 19 Jul 2008, Philip Langdale wrote:
> sets up an rfkill device and a polled input device to track the state of the
> hardware kill-switch. One entertaining fact about these Toshibas is that the

Soft NAK.

Please have a look at rfkill in wireless-testing (it is going in with the
merge of the net tree, so it will be in mainline really soon). rfkill has
seen some changes, and no little ammount of that work was to make platform
drivers like thinkpad-acpi and toshiba-acpi work better with rfkill. The
documentation in Documentation/rfkill.txt was expanded and improved as well,
and will help you get a better picture of how it should work. The rfkill
changes should also be available in wireless-compat, and they are

Please consider updating your patch to the new style rfkill class. A quick
look at your patch shows that it would benefit from the new
RFKILL_STATE_HARD_BLOCKED, and maybe to some rework to separate the
bluetooth rfkill controller and the input device switch better. Depending
on the existence of ACPI GPE events when the switch changes state on
Toshibas, you may even be able to get rid of some of the polling...

If you rework/repost your patch, please CC Ivo (the rfkill maintainer) and
the linux-wireless mailing list. If you want me to try to help review the
patch as well, please also add me to the CC.

"One disk to rule them all, One disk to find them. One disk to bring
them all and in the darkness grind them. In the Land of Redmond
where the shadows lie." -- The Silicon Valley Tarot
Henrique Holschuh
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at