Re: [Patch] kexec: remove redundant if-else

From: Eric W. Biederman
Date: Fri Jul 18 2008 - 16:12:39 EST

WANG Cong <xiyou.wangcong@xxxxxxxxx> writes:

> These if-else's can be removed.

Why? That appears to be pointless code style thrashing.

Converting code with a single return into code with multiple returns.
Which arguably makes it harder to prove properties about.

Further if you want to use the style you suggest a label name like err
is better than the name out.

But in this case where we have multiple results I don't like the proposed
change in style at all. Especially with no rational.

To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at