Re: [PATCH] x86,pci: dmi check for mackpro 2.2 mmconf

From: Yinghai Lu
Date: Fri Jul 18 2008 - 13:54:39 EST


On Fri, Jul 18, 2008 at 10:49 AM, H. Peter Anvin <hpa@xxxxxxxxx> wrote:
> Yinghai Lu wrote:
>>
>> On Fri, Jul 18, 2008 at 10:44 AM, H. Peter Anvin <hpa@xxxxxxxxx> wrote:
>>>
>>> Yinghai Lu wrote:
>>>>
>>>> change the mconf bus range from [0,0xff] to to [0, 0x3f]
>>>> to match range [0xf0000000, 0xf4000000) in e820 tables.
>>>>
>>>> Signed-off-by: Yinghai Lu <yhlu.kernel@xxxxxxxxx>
>>>> Tested-by: Jack Howarth <howarth@xxxxxxxxxxxxxxxxx>
>>>
>>> Why is this hard-coded instead of discovered dynamically?
>>
>> you mean according to the range reserved in e820 to find out bus range
>> that should be used for mmconf?
>
> That would make sense, since you're truncating the mmconf range based on
> some arbitrary limit. Even better would be to query the hardware register
> which is responsible for the truncation.

OK

will rework pci_mmcfg_reject_broken to
reduce size and check with is_acpi_reserved/e820_mapped to update end_bus_number

YH
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/