Re: [PATCH 6/7] dynamic debug v2 - convert cpufreq

[Dominik Brodowski]

On Thu, Jul 17, 2008 at 02:15:31PM -0700, Greg KH wrote:
> On Thu, Jul 17, 2008 at 05:05:32PM -0400, Jason Baron wrote:
> > --- a/arch/x86/kernel/cpu/cpufreq/acpi-cpufreq.c
> > +++ b/arch/x86/kernel/cpu/cpufreq/acpi-cpufreq.c
> > @@ -25,6 +25,7 @@
> >   * ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> >   */
> >  
> > +#include <linux/dynamic_debug_cpufreq.h>
> >  #include <linux/kernel.h>
> >  #include <linux/module.h>
> >  #include <linux/init.h>
> 
> kernel.h includes dynamic_debug.h right?  Then why not just put the
> _cpufreq.h stuff in the current cpufreq.h file(s)?

Seconded. Makes the cpufreq-related patch even smaller, for we won't have to
touch all drivers.

On Thu, Jul 17, 2008 at 05:05:32PM -0400, Jason Baron wrote:
> > > +#if defined(CONFIG_CPU_FREQ_DEBUG) || defined (CONFIG_DYNAMIC_PRINTK_DEBUG)
> > ...
> > > +#if defined(CONFIG_CPU_FREQ_DEBUG) || defined (CONFIG_DYNAMIC_PRINTK_DEBUG)
> > 
> > can't we just depend on thing on another?
> > 
> 
> We could make CONFIG_CPU_FREQ_DEBUG force CONFIG_DYNAMIC_PRINTK_DEBUG to be on.
> However, i'm trying to allow CONFIG_CPU_FREQ_DEBUG to be turned on without
> enabling CONFIG_DYNAMIC_PRINTK_DEBUG. That's consistent with how i'm trying to
> do this patch series. That is, individual subsystems can turn their respective
> debugging on without forcing on CONFIG_DYNAMIC_PRINTK_DEBUG.

Makes sense, and we can discuss depending one thing on another later on. 

Looking forward to seeing this infrastructure merged. I guess it will help a
lot.

Best,
	Dominik
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/