Re: [build fix] Re: [GIT PATCH] SCSI part 1

[Ingo Molnar]

* Matthew Wilcox <matthew@xxxxxx> wrote:

> On Wed, Jul 16, 2008 at 04:18:05PM +0200, Ingo Molnar wrote:
> > btw., about the technical aspects of the solution, i'm not sure i like 
> > these big #ifdef blocks:
> 
> It's partly the nature of the beast.  There's already several large
> #ifdef blocks in compat_ioctl.c -- CONFIG_NET, CONFIG_VT, 
> #CONFIG_SPARC, etc.  I think what would help is a bit more grouping so 
> #individual blocks get bigger.

yeah, that's OK - but why is scsi.h #ifdef-ed? For example we can 
include blkdev.h without #ifdef CONFIG_BLOCK.

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/