Re: [PATCH] V4L: Link tuner before saa7134

From: hermann pitton
Date: Tue Jul 15 2008 - 19:16:55 EST


Hi Simon,

Am Dienstag, den 15.07.2008, 22:40 +0100 schrieb Simon Arlott:
> If saa7134_init is run before v4l2_i2c_drv_init (tuner),
> then saa7134_board_init2 will try to set the tuner type
> for devices that don't exist yet. This moves tuner to
> before all of the device-specific drivers so that it's
> loaded early enough on boot.
>
> Signed-off-by: Simon Arlott <simon@xxxxxxxxxxx>
> ---
> Resend... I accidentally left the git-send-email headers in.
>
> Mailman appears to be easily confused too:
> http://www.linuxtv.org/pipermail/linux-dvb/2008-July/027205.html

the saa713x maintainer after Gerd is actually Hartmut.

He might not have always the time for it immediately, but should have a
copy of what is going on.

Actually, these problems are within the build system and should not even
come down to a driver maintainer.

The crowd here is used to have some trouble concerning the build, best
was when guys like Trent did watch out for it before we had some impact.

Cheers,
Hermann

> drivers/media/video/Makefile | 4 ++--
> 1 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/media/video/Makefile b/drivers/media/video/Makefile
> index ecbbfaa..6b0af12 100644
> --- a/drivers/media/video/Makefile
> +++ b/drivers/media/video/Makefile
> @@ -18,6 +18,8 @@ ifeq ($(CONFIG_VIDEO_V4L1_COMPAT),y)
> obj-$(CONFIG_VIDEO_DEV) += v4l1-compat.o
> endif
>
> +obj-$(CONFIG_VIDEO_TUNER) += tuner.o
> +
> obj-$(CONFIG_VIDEO_BT848) += bt8xx/
> obj-$(CONFIG_VIDEO_IR_I2C) += ir-kbd-i2c.o
> obj-$(CONFIG_VIDEO_TVAUDIO) += tvaudio.o
> @@ -84,8 +86,6 @@ obj-$(CONFIG_VIDEO_HEXIUM_GEMINI) += hexium_gemini.o
> obj-$(CONFIG_VIDEO_DPC) += dpc7146.o
> obj-$(CONFIG_TUNER_3036) += tuner-3036.o
>
> -obj-$(CONFIG_VIDEO_TUNER) += tuner.o
> -
> obj-$(CONFIG_VIDEOBUF_GEN) += videobuf-core.o
> obj-$(CONFIG_VIDEOBUF_DMA_SG) += videobuf-dma-sg.o
> obj-$(CONFIG_VIDEOBUF_VMALLOC) += videobuf-vmalloc.o
> --
> 1.5.6.2
>

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/