Re: [PATCH] block: fix q->max_segment_size checking in blk_recalc_rq_segmentsabout VMERGE

From: Mikulas Patocka
Date: Tue Jul 15 2008 - 11:48:38 EST


Even if we fix it now, the question is: how long it will stay fixed? Until
someone makes another change to struct device that restricts boundaries on
some wacky hardware.

I'm not sure how the boundary restriction of a device can break
the VMERGE accounting.

Because block layer code doesn't know anything about the device, pci access restrictions and so on.

Someone already broken DaveM's Sparc64 merging by adding boundaries (it was broken even before, but these boundary checks made it worse).

Mikulas
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/