Re: [PATCH] ALSA Au1xpsc: psc not disabled when TX is idle

[Manuel Lauss]

On Tue, Jul 15, 2008 at 02:44:24PM +0200, Roel Kluin wrote:
> Untested patch
> ---
> TX idleness isn't tested, but RX twice. PSC is not disabled when TX is idle
> 
> Signed-off-by: Roel Kluin <roel.kluin@xxxxxxxxx>
> ---
> diff --git a/sound/soc/au1x/psc-i2s.c b/sound/soc/au1x/psc-i2s.c
> index ba4b5c1..9384702 100644
> --- a/sound/soc/au1x/psc-i2s.c
> +++ b/sound/soc/au1x/psc-i2s.c
> @@ -231,7 +231,7 @@ static int au1xpsc_i2s_stop(struct au1xpsc_audio_data *pscdata, int stype)
> 
>         /* if both TX and RX are idle, disable PSC */
>         stat = au_readl(I2S_STAT(pscdata));
> -       if (!(stat & (PSC_I2SSTAT_RB | PSC_I2SSTAT_RB))) {
> +       if (!(stat & (PSC_I2SSTAT_TB | PSC_I2SSTAT_RB))) {
>                 au_writel(0, I2S_CFG(pscdata));
>                 au_sync();
>                 au_writel(PSC_CTRL_SUSPEND, PSC_CTRL(pscdata));

Ah, stupid copy-paste error. Thanks!

Acked-by: Manuel Lauss <mano@xxxxxxxxxxxxxxxxxxxxxxx>

-- 
 Manuel Lauss
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/