Re: [PATCH] ip2: avoid add_timer() with pending timer

From: Alan Cox
Date: Mon Jul 14 2008 - 10:30:20 EST


On Mon, 14 Jul 2008 11:49:55 +0900
Akinobu Mita <akinobu.mita@xxxxxxxxx> wrote:

> add_timer() is not suppose to be called when the timer is pending.
> ip2 driver attempts to avoid that condition by setting and resetting
> a flag (TimerOn) in timer function. But there is some gap between
> add_timer() and setting TimerOn.
>
> This patch fix this problem by using mod_timer() and remove TimerOn
> which has been unnecessary by this change.
>
> Signed-off-by: Akinobu Mita <akinobu.mita@xxxxxxxxx>
> Cc: Michael H. Warfield <mhw@xxxxxxxxxxxx>

Acked-by: Alan Cox <alan@xxxxxxxxxx>

Queued for ttydev tree

Alan
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/