Re: [PATCH] qla1280: use request_firmware

[Jes Sorensen]

Jaswinder Singh wrote:
> this is a first draft; please be kind :)
>
> Firmware blob is little endian looks like this...
> 	unsigned char  Version1
> 	unsigned char  Version2
> 	unsigned char  Version3
> 	unsigned char  Padding
> 	unsigned short start_address
> 	unsigned short data

Hello,

As the maintainer of this driver I am going to say that I think this is
a stupid change. Yes I know that politically there's a move to make
everything use request firmware. However for my boot device, this is
going to be a royal pain in the butt for developers who wish to boot
test kernels with a / sitting on a 1280.

IMHO this patch brings us nothing, but provides a lot of unnecessary
hassle for users.

Nacked-By: Jes Sorensen <jes@xxxxxxx>

Regards,
Jes
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/