Re: [PATCH 2.6.25.10 1/2] libata: fix locking for kmap_atomic

From: Andrew Morton
Date: Sun Jul 13 2008 - 04:26:51 EST


On Sun, 13 Jul 2008 01:27:36 +0200 "Jakub W. Jozwicki" <jozwicki@xxxxxxxx> wrote:

> Change locking surrounding kmap_atomic from local_irqsave to
> local_irqsave_nort. This fixes issues with PREEMPT_RT.
>

I assume this is a -rt kernel patch.

>
> --- linux-2.6.25.10/drivers/ata/libata-core.c 2008-07-03 05:46:47.000000000
> +0200
> +++ linux-2.6.25.10-rt7/drivers/ata/libata-core.c 2008-07-12
> 23:59:33.132140258 +0200
> @@ -5157,14 +5157,14 @@
> unsigned long flags;
>
> /* FIXME: use a bounce buffer */
> - local_irq_save(flags);
> + local_irq_save_nort(flags);

eww. If we're going to have to do stuff like this in mainline then
there might be a revolt.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/