Re: [PATCH 17/18] [GFS2] Remove support for unused and pointlessflag

From: linux-os (Dick Johnson)
Date: Fri Jul 11 2008 - 08:50:08 EST



On Fri, 11 Jul 2008, Steven Whitehouse wrote:

> Hi,
>
> On Fri, 2008-07-11 at 07:19 -0400, linux-os (Dick Johnson) wrote:
>> On Fri, 11 Jul 2008 swhiteho@xxxxxxxxxx wrote:
>>
>>> From: Steven Whitehouse <swhiteho@xxxxxxxxxx>
>>>
>>> The ability to mark files for direct i/o access when opened
>>> normally is both unused and pointless, so this patch removes
>>> support for that feature.
>> [Snipped...]
>>
>> So linux is no longer going to support commercial databases?
[Snipped...]

>>
> No, thats not what it means...., but perhaps I could have explained it
> better. You can still use O_DIRECT flags in open syscalls in exactly the
> same way as before. What this patch removes is the (never used, and IMHO
> pointless) feature of being able to set a flag on the inode (via
> chattr/setattr) to force open's to set O_DIRECT in every case, even when
> the application didn't ask for it. The reason that its pointless is that
> applications which don't otherwise support O_DIRECT are very unlikely to
> supply suitably aligned buffers and I/O requests, so that overriding the
> O_DIRECT flag for such applications will most likely result in an I/O
> error.
>
> GFS2 will still support O_DIRECT just the same as it has always done,
> and this doesn't affect any other filesystem's support for that feature
> either,
>
> Steve.

Thanks for the clarification!

Cheers,
Dick Johnson
Penguin : Linux version 2.6.22.1 on an i686 machine (5588.28 BogoMips).
My book : http://www.AbominableFirebug.com/
_


****************************************************************
The information transmitted in this message is confidential and may be privileged. Any review, retransmission, dissemination, or other use of this information by persons or entities other than the intended recipient is prohibited. If you are not the intended recipient, please notify Analogic Corporation immediately - by replying to this message or by sending an email to DeliveryErrors@xxxxxxxxxxxx - and destroy all copies of this information, including any attachments, without reading or disclosing them.

Thank you.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/