Re: [PATCH] uio: uio_pdrv_genirq V2

[Uwe Kleine-König]

Hello,

Magnus Damm wrote:
> On Thu, Jul 10, 2008 at 7:58 PM, Hans J. Koch <hjk@xxxxxxxxxxxxx> wrote:
> > On Thu, Jul 10, 2008 at 08:56:39AM +0200, Uwe Kleine-König wrote:
> >> > +       ret = uio_register_device(&pdev->dev, priv->uioinfo);
> >> > +       if (ret) {
> >> > +               dev_err(&pdev->dev, "unable to register uio device\n");
> >> > +               goto bad1;
> >> > +       }
> >> > +
> >> > +       platform_set_drvdata(pdev, priv);
> >> This should probably go before uio_register_device.  (Uups, this is an
> >> issue for uio_pdrv, too.)
> >
> > Yes, because uio_register_device will enable the irq, and you might
> > arrive in the handler without having your platform data in place.
> 
> I'd say that this is a non-issue.
> 
> Only uio_pdrv_genirq_remove() is using the platform data. This
> remove() method won't be called if uio_pdrv_genirq_probe() returns
> failure. The UIO subsystem is using uioinfo->priv which of course is
> set up correctly already.
... let me check ... yes, it's true.  So it only looks ugly :-)

Uwe

-- 
Uwe Kleine-König, Software Engineer
Digi International GmbH Branch Breisach, Küferstrasse 8, 79206 Breisach, Germany
Tax: 315/5781/0242 / VAT: DE153662976 / Reg. Amtsgericht Dortmund HRB 13962
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/