Re: [PATCH] x86_64: fix delayed signals

From: Linus Torvalds
Date: Thu Jul 10 2008 - 18:53:10 EST




On Thu, 10 Jul 2008, Roland McGrath wrote:
>
> > But if you really want that behaviour, then re-introducing the loop would
> > likely be the better approach (or should be combined), since I think you
> > effectively just re-introduced it (at a much bigger granularity).
>
> I don't think so. Firstly, TIF_SIGPENDING is not the only flag in
> question. There are other reasons to re-enter do_notify_resume().
> If those are set during signal processing et al, they should take
> effect before going back to user mode.

You're ignoring the background question - we expressly _stopped_ doing
this long ago. So the real issue was the ".. if you really .." part.

Do we really? What's the actual downside here?

Linus
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/