Re: [PATCH v2 2/4] mmc: Export internal host state through debugfs

From: Pierre Ossman
Date: Thu Jul 10 2008 - 04:34:13 EST


On Sat, 5 Jul 2008 15:44:36 +0200
Haavard Skinnemoen <haavard.skinnemoen@xxxxxxxxx> wrote:

> On Fri, 4 Jul 2008 19:45:56 +0200
> Pierre Ossman <drzeus-list@xxxxxxxxx> wrote:
>
> > I see that this version has no ifdef:s at all. Doesn't that mean a lot
> > of useless code if DEBUG_FS is not enabled? You embedded guys are
> > usually rather sensitive about such things. :)
>
> Hmm...looks like gcc does a pretty poor job of eliminating unreachable
> code, so we end up with about 1k of dead code in debugfs.o.
>
> I guess we'll have to throw in a couple of #ifdefs then...
>

Have you managed do have a look at this?

--
-- Pierre Ossman

Linux kernel, MMC maintainer http://www.kernel.org
rdesktop, core developer http://www.rdesktop.org

WARNING: This correspondence is being monitored by the
Swedish government. Make sure your server uses encryption
for SMTP traffic and consider using PGP for end-to-end
encryption.

Attachment: signature.asc
Description: PGP signature