Re: [RFC 00/15] x86_64: Optimize percpu accesses

From: Christoph Lameter
Date: Wed Jul 09 2008 - 15:13:40 EST


Jeremy Fitzhardinge wrote:

> No, they don't help at all, because they convert X_pda(Y) (which doesn't
> exist) into x86_X_percpu(pda.Y) (which also doesn't exist). They don't
> remove any #ifdef CONFIG_X86_64's. If you're going to tromp all over
> the source, you may as well do the most useful thing in the first step.

Well they help in the sense that the patches get rid of the special X_pda(Y) operations.
x86_X_percpu will then exist under 32 bit and 64 bit.

What is remaining is the task to rename

pda.Y -> Z

in order to make variable references the same under both arches. Presumably the Z is the corresponding 32 bit variable. There are likely a number of cases where the transformation
is trivial if we just identify the corresponding 32 bit equivalent.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/