Re: [PATCH] Mark i2o config broken on 64-bit platforms.

From: Alan Cox
Date: Wed Jul 09 2008 - 11:21:48 EST


On Wed, 09 Jul 2008 12:35:47 +0100
David Howells <dhowells@xxxxxxxxxx> wrote:

> Mark i2o config broken on 64-bit platforms as it generates these:
>
> In file included from drivers/message/i2o/config-osm.c:39:
> drivers/message/i2o/i2o_config.c: In function 'i2o_cfg_passthru':
> drivers/message/i2o/i2o_config.c:889: warning: cast to pointer from integer of different size
> drivers/message/i2o/i2o_config.c:945: warning: cast to pointer from integer of different size
>
> which are apparently non-trivial to fix (eg: inserting a cast through unsigned
> long is not correct according to Linus). This would be due to struct
> sg_simple_element only having a 32-bit addr_bus value.
>
> There are also a number of "TODO 64bit fix" comments.
>
> Signed-off-by: David Howells <dhowells@xxxxxxxxxx>


NAK - it appears to be broken for 64bit user space only
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/