Re: [PATCH 2/3] sched: terminate newidle balancing once at least one task has moved over

From: Nick Piggin
Date: Wed Jul 09 2008 - 04:10:40 EST


On Tuesday 08 July 2008 22:37, Gregory Haskins wrote:
> >>> On Tue, Jul 8, 2008 at 1:00 AM, in message
>
> <200807081500.18245.nickpiggin@xxxxxxxxxxxx>, Nick Piggin
>
> <nickpiggin@xxxxxxxxxxxx> wrote:
> > On Saturday 28 June 2008 06:29, Gregory Haskins wrote:
> >> Inspired by Peter Zijlstra.
> >>
> >> Signed-off-by: Gregory Haskins <ghaskins@xxxxxxxxxx>
> >
> > What happened to the feedback I sent about this?
> >
> > It is still nack from me.
>
> Ah yes. Slipped through the cracks...sorry about that.
>
> What if we did "if (idle == CPU_NEWLY_IDLE && need_resched())" instead?

Isn't that exactly the same thing because any task will preempt the idle
thread?
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/