Re: [PATCH] ext4: handle deleting corrupted indirect blocks

[Theodore Tso]

On Tue, Jul 08, 2008 at 03:42:00PM +0100, Duane Griffin wrote:
> +		if (bh2jh(this_bh))
> +			ext4_journal_dirty_metadata(handle, this_bh);
> +		else
> +			ext4_error(inode->i_sb, __func__,
> +				   "circular indirect block detected, "
> +				   "inode=%lu, block=%lu",
> +				   inode->i_ino, this_bh->b_blocknr);

this_bh->b_blocknr is a sector_t, which could be 64-bits.  So this
should be:

			ext4_error(inode->i_sb, __func__,
				   "circular indirect block detected, "
				   "inode=%lu, block=%llu",
				   inode->i_ino,
				   (unsigned long long) this_bh->b_blocknr);

I think.

With this change, I've included your three patches into the ext4 patch
queue.

						- Ted

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/