Re: [Patch 06/10] mfd: PCAP driver for the Motorola EZX GSM mobilephones

[Eric Miao]

> o Eric, what do you like the PCAP_REDIRECT_IRQ flag to do?
> 

I'm seeing the following the block of code in the original patch:
 
+/* PCAP */
+static int ezx_pcap_init(void)
+{

...

+	/* redirect all interrupts to AP */
+	if (!(machine_is_ezx_a780() || machine_is_ezx_e680()))
+		ezx_pcap_write(PCAP_REG_INT_SEL, 0);
+
+	return 0;
+}

that prevent this driver from being generic, a flag of PCAP_REDIRECT_IRQ
might be used to decide the writing to PCAP_REG_INT_SEL is necessary.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/