Re: next-0708: build failure at drivers/pci/pci-acpi.c

From: Rafael J. Wysocki
Date: Tue Jul 08 2008 - 12:56:43 EST


On Tuesday, 8 of July 2008, Alexander Beregalov wrote:
> 2008/7/8 Rafael J. Wysocki <rjw@xxxxxxx>:
> > On Tuesday, 8 of July 2008, Alexander Beregalov wrote:
> >> Hi Rafael
> >>
> >> drivers/pci/pci-acpi.c: In function 'acpi_pci_sleep_wake':
> >> drivers/pci/pci-acpi.c:311: error: implicit declaration of function
> >> 'acpi_pm_device_sleep_wake'
> >
> > I guess this is a compilation with CONFIG_ACPI=y and CONFIG_PM_SLEEP unset.
> Indeed.
> >
> > In that case the appended patch should help. Please test and report back (I
> > can't test linux-next compilation at the moment).
>
> Compilation test passed and the kernel can boot.

Thanks!

Jesse, could you please apply the patch below to the linux-next branch, on top
of the PCI wake-up patchset?

Rafael

---
From: Rafael J. Wysocki <rjw@xxxxxxx>

PCI ACPI: Fix compilation of pci-acpi.c

Fix compilation of pci-acpi.c with CONFIG_ACPI set and
CONFIG_PM_SLEEP unset.

Signed-off-by: Rafael J. Wysocki <rjw@xxxxxxx>
Tested-by: Alexander Beregalov <a.beregalov@xxxxxxxxx>
---
include/acpi/acpi_bus.h | 4 ++++
1 file changed, 4 insertions(+)

Index: linux-next/include/acpi/acpi_bus.h
===================================================================
--- linux-next.orig/include/acpi/acpi_bus.h
+++ linux-next/include/acpi/acpi_bus.h
@@ -388,6 +388,10 @@ static inline int acpi_pm_device_sleep_s
*p = ACPI_STATE_D0;
return ACPI_STATE_D3;
}
+static inline int acpi_pm_device_sleep_wake(struct device *d, bool b)
+{
+ return -ENOSYS;
+}
#endif /* !CONFIG_PM_SLEEP */

#endif /* CONFIG_ACPI */
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/