Re: [PATCH] bnx2 - use request_firmware()

From: Alan Cox
Date: Tue Jul 08 2008 - 03:22:44 EST


> so make the firmware part of the module if the driver is compiled as a
> module. this way if the driver (and firmware) end up not being used they
> don't take up any space. this seems a lot simpler (as well as more
> reliable) then adding a mandatory dependancy on a different userspace
> tool.

For the majority of drivers that would be a serious regression as they
load the firmware when needed, which is not when loaded. In some cases
there are many sets of firmware and only one is needed according to the
device, and only needed once per device detect.

It might well make sense for tg3 although even there it seems most tg3
work fine without loading new firmware, and examples like aic7xxx where
the firmware and code must match.

Alan
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/