Re: [PATCH] bnx2 - use request_firmware()

From: Alan Cox
Date: Tue Jul 08 2008 - 03:12:19 EST


> The firmware needs to be reloaded every time the chip resets.
> You're not saving anything/

> See above, you aren't saving anything. The firmware needs to stay
> around so it can be reloaded into the card during exceptions.
>
> That is, unless you want a more failure prone system.

Ok so if tg3 always needs the same firmware and always needs it in memory
then maybe it isn't a significant candidate for request_firmware beyond
the neatness of distribution. I note the firmware hasn't changed in years
so it can easily be shipped separately and the one package would have
done for all this time.

> > Driver authors aren't God.
>
> They (actually, more specifically the maintainers) to a certain extent
> are, because they are the ones who eat doo-doo when something explodes.

So do the distributions and the users.

Alan
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/