Re: [PATCH] bnx2 - use request_firmware()

From: David Miller
Date: Mon Jul 07 2008 - 17:38:19 EST


From: "Michael Chan" <mchan@xxxxxxxxxxxx>
Date: Mon, 07 Jul 2008 11:56:21 -0700

> The driver is not guaranteed to be backward or forward compatible with
> the firmware. It may be forward compatible in most cases (new firmware
> may work with older driver) but there is no guarantee because it is
> simply not necessary in the current model.
>
> We also only test 1 driver + 1 firmware and no other combinations.
> Separating the 2 makes things more complicated and prone to random
> failures.

Right.

I want to know what the actual "use case" is of this new stuff.

Who in the world is going to actually want request_firmware() to find
a firmware image other than the one which has been properly tested
together with the driver by the driver maintainer?

What "use case" is there other than the desire to seperate out the
firmware in order to skirt the legal issues?

These drivers which include their own firmware and do not use
request_firmware() are functioning perfectly fine, have done so for
many many years, and gain zero by having request_firmware() support.

I think it is, in fact, the driver maintainer's perogative of whether
they want request_firmware() to be supported by their driver or not.
It is they who have to deal with any possible fallout.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/