Re: [PATCH] fix build error of driver/mfd/tc6393xb.c

From: Takashi Iwai
Date: Mon Jul 07 2008 - 12:09:32 EST


At Sat, 5 Jul 2008 10:13:09 -0700,
David Brownell wrote:
>
> On Saturday 05 July 2008, Dmitry Baryshkov wrote:
> >
> > > > I'm not sure whether it's a better fix at this moment.
> > >
> > > Which platform is it which is trying to declare that it has
> > > an implementation (HAVE_GPIO_LIB) of an interface that it
> > > doesn't support (GENERIC_GPIO unset) ??
> >
> > the powerpc with PPC_MPC52xx=y, PPC_MPC5200_GPIO=y
>
> The most natural fix is to have the Kconfig for PPC_MPC52xx
> select both GENERIC_GPIO and HAVE_GPIO_LIB.

Yes. I, however, still feel uneasy by the fact that the combination
GENERIC_GPIO=n and HAVE_GPIO_LIB=y doesn't work. We should either fix
it to work or disallow the combination.


thanks,

Takashi
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/