Re: [patch 12/13] GRU Driver V3 - export is_uv_system(), zap_page_range()& follow_page()

From: Christoph Lameter
Date: Mon Jul 07 2008 - 10:46:14 EST


Christoph Hellwig wrote:
> On Thu, Jul 03, 2008 at 04:34:00PM -0500, steiner@xxxxxxx wrote:
>> +EXPORT_SYMBOL_GPL(zap_page_range);
>>
>> /*
>> * Do a quick page-table lookup for a single page.
>> @@ -1089,6 +1090,7 @@ no_page_table:
>> }
>> return page;
>> }
>> +EXPORT_SYMBOL_GPL(follow_page);
>
> NACK.
>
> These should never be called by a driver and suggest you need to rething
> your VM integration in this driver.

Well here we cannot run get_user_pages() since the context is atomic. What other choice is there?

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/