Re: Lockless/Get_User_Pages_Fast causes Xorg 1.4.99.* to lock

From: Martin Schwidefsky
Date: Mon Jul 07 2008 - 07:09:20 EST


On Mon, Jul 7, 2008 at 12:39 PM, Hugh Dickins <hugh@xxxxxxxxxxx> wrote:
> On Mon, 7 Jul 2008, Nick Piggin wrote:
>>
>> I think we need a similar fix for s390 too. If so, then it really should
>> get into 2.6.26, but this late in the release, I hope an s390 maintainer
>> might be able to test and verify the fix?
>
> Wow, yes, I hadn't realized s390 is ahead of the game there: glad you're
> back to spot that. But yes, we'd prefer maintainer to confirm and push.
>
>
> [PATCH]] s390: protect _PAGE_SPECIAL bit against mprotect
>
> Stop mprotect's pte_modify from wiping out the s390 pte_special bit, which
> caused oops thereafter when vm_normal_page thought X's abnormal was normal.
>
> Signed-off-by: Nick Piggin <npiggin@xxxxxxx>
> Acked-by: Hugh Dickins <hugh@xxxxxxxxxxx>

s390 will definitely need this. Loosing the pte special bit is not
good. I'll prepate
a please pull right away. Thanks of pointing this out.

--
blue skies,
Martin
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/