Re: [PATCH 0/6] AMD IOMMU updates

[FUJITA Tomonori]

On Fri, 4 Jul 2008 11:52:13 +0200
Ingo Molnar <mingo@xxxxxxx> wrote:

> 
> * Joerg Roedel <joerg.roedel@xxxxxxx> wrote:
> 
> > Hi,
> > 
> > this series of patches contain some updates to the AMD IOMMU code 
> > currently in tip/master. The updates address some objections discussed 
> > on the initial patches and also contain optimization and small code 
> > cleanup. The code with these updates is tested on real hardware under 
> > load and showed no problems.
> 
> applied to tip/x86/amd-iommu and pushed that topic out, thanks Joerg.
> 
> also, i've integrated it into tip/master as well (will push that out
> after some testing).
> 
> The IOMMU driver code seems to be getting into good shape, so i've also 
> added the topic to auto-x86-next, which means it will go into linux-next 
> on the next iteration (in 1-2 days). Does anyone see any remaining 
> problems?

Not a showstopper but I like to see the cleanups of the kernel
parameters, as I said before. The AMD IOMMU has two parameters,
amd_iommu=isolate and amd_iommu_size=32M|64M|128M|256M|512M|1G

The former might be useful for the VT-d. The latter is useful for most
of the IOMMU drivers. So I think that it would be better to make them
common parameters.

And if we can change the existing kernel parameters, I think that it
would be better to convert some of the x86 IOMMU parameters to common
parameters.


BTW, "[PATCH 4/6] AMD IOMMU: honor iommu=off instead of amd_iommu=off"
patch in auto-x86-next needs update the kernel parameter.

=
From: FUJITA Tomonori <fujita.tomonori@xxxxxxxxxxxxx>
Subject: [PATCH] AMD IOMMU: fix kernel parameter

amd_iommu=off was replaced with a common parameter, iommu=off.

Signed-off-by: FUJITA Tomonori <fujita.tomonori@xxxxxxxxxxxxx>
---
 Documentation/kernel-parameters.txt |    1 -
 1 files changed, 0 insertions(+), 1 deletions(-)

diff --git a/Documentation/kernel-parameters.txt b/Documentation/kernel-parameters.txt
index cd98762..1a6bb46 100644
--- a/Documentation/kernel-parameters.txt
+++ b/Documentation/kernel-parameters.txt
@@ -274,7 +274,6 @@ and is between 256 and 4096 characters. It is defined in the file
 	amd_iommu=	[HW,X86-84]
 			Pass parameters to the AMD IOMMU driver in the system.
 			Possible values are:
-			off     - disable the driver for AMD IOMMU
 			isolate - enable device isolation (each device, as far
 			          as possible, will get its own protection
 			          domain)
-- 
1.5.5.GIT

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/