Re: [NET-NEXT PATCH 08/18] igb: Introduce multiple TX queues withinfrastructure

[David Miller]

From: Jeff Garzik <jeff@xxxxxxxxxx>
Date: Fri, 04 Jul 2008 08:43:10 -0400

> Jeff Kirsher wrote:
> > From: Peter P Waskiewicz Jr <peter.p.waskiewicz.jr@xxxxxxxxx>
> > 
> > This code adds multiple Tx queue infrastructure much like we
> > previously did in ixgbe. The MSI-X vector mapping is the bulk of
> > the change.
> > 
> > IAM can now be safely enabled and we've verified that it does
> > work correctly. We can also eliminate the tx ring lock.
> > 
> > Signed-off-by: Peter P Waskiewicz Jr <peter.p.waskiewicz.jr@xxxxxxxxx>
> > Signed-off-by: Mitch Williams <mitch.a.williams@xxxxxxxxx>
> > Signed-off-by: Auke Kok <auke-jan.h.kok@xxxxxxxxx>
> > ---
> > 
> >  drivers/net/igb/igb.h      |    6 +-
> >  drivers/net/igb/igb_main.c |  160 ++++++++++++++++++++++++++++++--------------
> >  2 files changed, 113 insertions(+), 53 deletions(-)
> 
> presumably this should wait for david to finish his multi-TX stuff?

Adding infrastructure now is a good thing.  I did something similar
for NIU, and the Broadcom folks have done similar for bnx2*.

That's why the NIU multiqueue TX patch in my series was only 10 lines
of changes, all the infrastructure and init was in the driver already :-)
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/