Re: *sigh* /proc/*/pagemap

[Linus Torvalds]

On Fri, 4 Jul 2008, Andrew Morton wrote:
>  	int pagecount;
>  	int ret = -ESRCH;
> +	static struct mm_walk pagemap_walk;
>  
...
>  
> +	pagemap_walk.pmd_entry = pagemap_pte_range;
> +	pagemap_walk.pte_hole = pagemap_pte_hole;
> +	pagemap_walk.mm = mm;
> +	pagemap_walk.private = ±
> +

No can do. You have one single pagemap_walk, but perhaps multiple users, 
who all disagree about what it should contain.

Quite frankly, I think we should just remove the whole f*cking crap. I 
think it's also potentially a security hole to give physical page 
information and swap info - even if it's just your own pages.

Matt, can you explain what the point was of this whole thing? I'm really 
_this_ close to just removing the POS right now. It's been a big source of 
bugs, and it looks entirely pointless.

		Linus
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/