Re: [PATCH] fix build error of driver/mfd/tc6393xb.c

[Takashi Iwai]

At Fri, 4 Jul 2008 17:22:35 +0400,
Dmitry Baryshkov wrote:
> 
> On Fri, Jul 04, 2008 at 02:59:18PM +0200, Takashi Iwai wrote:
> > At Fri, 4 Jul 2008 16:42:56 +0400,
> > Dmitry Baryshkov wrote:
> > > 
> > > On Fri, Jul 04, 2008 at 02:04:30PM +0200, Takashi Iwai wrote:
> > > > At Fri, 4 Jul 2008 15:47:55 +0400,
> > > > Dmitry Baryshkov wrote:
> > > > > 
> > > > > On Fri, Jul 04, 2008 at 01:20:42PM +0200, Takashi Iwai wrote:
> > > > > > Fix the build of tc6393xb  due to missing definition of struct
> > > > > > gpio_chip.
> > > > > > 
> > > > > > Signed-off-by: Takashi Iwai <tiwai@xxxxxxx>
> > > > > > 
> > > > > > ---
> > > > > > diff --git a/drivers/mfd/Kconfig b/drivers/mfd/Kconfig
> > > > > > index 9f93c29..2981da4 100644
> > > > > > --- a/drivers/mfd/Kconfig
> > > > > > +++ b/drivers/mfd/Kconfig
> > > > > > @@ -44,7 +44,7 @@ config HTC_PASIC3
> > > > > >  
> > > > > >  config MFD_TC6393XB
> > > > > >  	bool "Support Toshiba TC6393XB"
> > > > > > -	depends on HAVE_GPIO_LIB
> > > > > > +	depends on HAVE_GPIO_LIB && GENERIC_GPIO
> > > > > >  	select MFD_CORE
> > > > > >  	help
> > > > > >  	  Support for Toshiba Mobile IO Controller TC6393XB
> > > > > 
> > > > > Which configuration does provide HAVE_GPIO_LIB but not GENERIC_GPIO?
> > > > 
> > > > The below is the config with which I got the error.
> > > 
> > > The proper fix probably is to make PPC_MPC5200_GPIO also select
> > > GENERIC_GPIO. I don't think that building GPIO_LIB w/o GENERIC_GPIO
> > > should be supported.
> > 
> > [Added David to Cc]
> > 
> > Then HAVE_GPIO_LIB should depend on GENERIC_GPIO.
> > Or, linux/gpio.h should be fixed so that the code can be built
> > properly without GENERIC_GPIO.
> 
> IIRC selected symbols don't propagate their depends.

Then HAVE_GPIO_LIB selects GENERIC_GPIO.  Right now, it's a missing
dependency.

> Also linux/gpio.h don't have anything in common with HAVE_GPIO_LIB.

That's another side of the problem.


Takashi
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/