Re: [PATCH 06/11] sysfs: Implement sysfs tagged directory support.

From: Daniel Lezcano
Date: Thu Jul 03 2008 - 14:30:18 EST


Tejun Heo wrote:
Hello,

Eric W. Biederman wrote:
Daniel Lezcano <dlezcano@xxxxxxxxxx> writes:

The kobject events are sent through a netlink message which is not currently per
network namespace. Shouldn't be useful to have a way to retrieve from the
kobject the network namespace or the uevent socket associated with it ? IMHO
having idr in the kobject + netns pointer associated may help to handle the
sysfs isolation and makes the uevent per namespace trivial, no ?
Grumble. I have been conveniently been forgetting about that socket.
Similarly we have the user mode helpers to deal with.

For this conversation there is a simple answer. All of that is in the
kobject layer, and works even when you compile sysfs out of your kernel.
Therefore it is a separate problem. And sysfs idr tags have nothing
to do with it.

It is most definitely something we need to come back to. I bet there
are some interesting interactions when you have multiple network devices
with the same name generating events.

Related delta: I've been thinking that uevents should be part of sysfs
not kobject as that's what the userland is gonna associate the event
with. Would that solve the problem you're thinking about?

uevents can work with the network namespaces being compiled in and the sysfs compiled out. AFAICS, uevents will be unable to handle multiple network namespaces if it is tied with sysfs, no ?
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/