Re: mce_64.c: mce_cpu_quirks being ignored

From: Andi Kleen
Date: Thu Jul 03 2008 - 09:22:28 EST


Ingo Molnar wrote:
> * Venki Pallipadi <venkatesh.pallipadi@xxxxxxxxx> wrote:
>
>>> Venki, I did a patch for dynamic banks anyways, but haven't
>>> submitted it yet.
>> Yes. That particular quirk getting ignored was a bug. Below patch
>> fixes the bug, until we have the dynamic banks support.
>>
>> sysfs choice configuration should not have any issues with the earlier
>> patch as we look for NR_SYSFS_BANKS in do_machine_check().
>>
>> Signed-off-by: Venkatesh Pallipadi <venkatesh.pallipadi@xxxxxxxxx>
>
> applied to tip/x86/mce - thanks Venki.

The dynamic banks patch is posted
http://marc.info/?l=linux-kernel&m=121493114604815&w=2
, but it turned out it requires
a sysfs infrastructure change for the auto-generated attributes.
I did that, but the patch is rather large
(http://marc.info/?l=linux-kernel&m=121493094104469&w=2)

Greg said he would queue the change, so dynamic banks could
be added (replacing Venki's two patches), but it would need
to be submitted after the infrastructure change.

-Andi
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/