Re: [PATCH] sparc64: fix up bus_id changes in sparc core code

From: David Miller
Date: Thu Jul 03 2008 - 09:02:43 EST


From: Greg Kroah-Hartman <gregkh@xxxxxxx>
Date: Wed, 2 Jul 2008 08:36:51 -0700

> --- a/arch/sparc64/kernel/pci.c
> +++ b/arch/sparc64/kernel/pci.c
> @@ -408,7 +408,7 @@ struct pci_dev *of_create_pci_dev(struct
> dev->class = class >> 8;
> dev->revision = class & 0xff;
>
> - sprintf(dev->dev.bus_id, "%04x:%02x:%02x.%d", pci_domain_nr(bus),
> + dev_set_name(&dev->dev, "%04x:%02x:%02x.%d", pci_domain_nr(bus),
> dev->bus->number, PCI_SLOT(devfn), PCI_FUNC(devfn));
>
> if (ofpci_verbose)

Those lines read:

sprintf(pci_name(dev), "%04x:%02x:%02x.%d", pci_domain_nr(bus),
dev->bus->number, PCI_SLOT(devfn), PCI_FUNC(devfn));

in Linus's current tree.

What are you patching against? That first argument is not
dev->dev.bus_id in any tree I have sitting here, it's always
pci_name() :-)
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/