Re: [PATCH] mfd: fix a bug in the asic3 irq demux code

[Andrew Morton]

On Wed, 2 Jul 2008 20:22:20 +0200
Samuel Ortiz <sameo@xxxxxxxxxxxxxx> wrote:

> Hi Andrew,
> 
> On Wed, Jul 02, 2008 at 10:53:03AM -0700, Andrew Morton wrote:
> > On Wed, 02 Jul 2008 19:42:53 +0200 Philipp Zabel <philipp.zabel@xxxxxxxxx> wrote:
> > 
> > > Wrong irq numbers were given to desc->handle_irq, which
> > > on some devices caused endless loops (asic3_irq_demux
> > > calling itself, basically).
> > > 
> > > Signed-off-by: Philipp Zabel <philipp.zabel@xxxxxxxxx>
> > > ---
> > >  drivers/mfd/asic3.c |    2 +-
> > >  1 files changed, 1 insertions(+), 1 deletions(-)
> > > 
> > > diff --git a/drivers/mfd/asic3.c b/drivers/mfd/asic3.c
> > > index 8e41130..59ec9c6 100644
> > > --- a/drivers/mfd/asic3.c
> > > +++ b/drivers/mfd/asic3.c
> > > @@ -308,7 +308,7 @@ static void asic3_irq_demux(unsigned int irq, struct irq_desc *desc)
> > >  		for (i = ASIC3_NUM_GPIOS; i < ASIC3_NR_IRQS; i++) {
> > >  			/* They start at bit 4 and go up */
> > >  			if (status & (1 << (i - ASIC3_NUM_GPIOS + 4))) {
> > > -				desc = irq_desc +  + i;
> > > +				desc = irq_desc + asic->irq_base + i;
> > >  				desc->handle_irq(asic->irq_base + i,
> > >  						 desc);
> > >  			}
> > 
> > hm, I seem to have a pile of mfd patches.  I'll look to offload those
> > on Samuel.
> > 
> > Samuel, will you be setting up an MFD git tree for linux-next?  (You
> > should, please).
> I have set up an mfd tree here: http://git.o-hand.com/?r=linux-mfd
> with a for-next branch.

OK, thanks.  Linus gets upset over git-over-http for some reason, so
I'd suggest that you move to kernel.org when that is set up.

Plus: I pull from lots of different git servers and it's quite common
that at least one of them is dead.  It was git://www.linux-m32r.org
yesterday.

> I havent asked Stephen to pull from it yet,
> and I havent Cc'ed you on the mfd patches that are sitting there as
> I was mostly setting things up. I will clean things up and re-apply
> them so that you get a notification for all the mfd patches that are
> already on -mm.
> 
> I also requested for an account on kernel.org, but I'm still waiting
> for an answer.

Cool.

I assume that sameo@xxxxxxxxxxxxxx is now the preferred address?  Will
samuel@xxxxxxxxxx continue to work?

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/