Re: [PATCH 001/002] linux-input: bcm5974-0.31: fixed resourceleak, removed work struct, device data struct introduced

[Andrew Morton]

On Tue, 1 Jul 2008 20:04:16 -0700 David Brownell <david-b@xxxxxxxxxxx> wrote:

> On Tuesday 01 July 2008, Andrew Morton wrote:
> > I dunno what USB driver normally use for their dma memory. __Perhaps
> > dma_alloc_coherent()?
> 
> kmalloc() as a rule ...

kmalloc(GFP_DMA)?  Hopefully not...

> dma_alloc_coherent() only makes sense if
> the buffer gets reused enough that the dma mapping ops (or as I
> think of them, cache maintainence ops) really hurt.
> 
> - Dave
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/