Re: next-0630: sparc64: build failed

[Ingo Molnar]

* Abhishek Sagar <sagar.abhishek@xxxxxxxxx> wrote:

> Hi Ingo/David,
> 
> CONFIG_MCOUNT currently controls the compilation with -pg flag and the 
> export of _mcount. But with ftrace, the former is redundant and the 
> latter should be made unconditional since _mcount is always defined. 
> In which case, does the inlined patch (untested) make sense? It should 
> solve the build failure as well.

hm, mcount is the facility - so it makes sense to have that defined. 
Here you basically hide CONFIG_MCOUNT:

> -ifeq ($(CONFIG_MCOUNT),y)
> -  KBUILD_CFLAGS += -pg
> +ifneq ($(CONFIG_FTRACE),y)
> +ifeq ($(CONFIG_STACK_DEBUG),y)
> +KBUILD_CFLAGS += -pg
> +endif
>  endif

via two conditions. I'm not sure that's a win and i found CONFIG_MCOUNT 
a logical switch - but it's David's call.

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/