Re: [PATCH 2/7] fat: Fix VFAT_IOCTL_READDIR_xxx and cleanup for userland

[OGAWA Hirofumi]

Christoph Hellwig <hch@xxxxxxxxxxxxx> writes:

>>  #include <linux/magic.h>
>> +#include <asm/byteorder.h>
>
> Why do we need this in the user-visible part of the header?

It was just moved from line below of this.

>> +struct __fat_dirent {
>> +	long		d_ino;
>> +	__kernel_off_t	d_off;
>> +	unsigned short	d_reclen;
>> +	char		d_name[256]; /* We must not include limits.h! */
>> +};
>
> Any reason this is not called fat_dirent? 

It was suggested, and I thought it's safe.
-- 
OGAWA Hirofumi <hirofumi@xxxxxxxxxxxxxxxxxx>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/