Re: Ctrl+C doesn't interrupt process waiting for I/O

From: Török Edwin
Date: Tue Jul 01 2008 - 05:01:26 EST


David Newall wrote:
> Elias Oltmanns wrote:
>
>> - if (!L_NOFLSH(tty)) {
>> - n_tty_flush_buffer(tty);
>> - tty_driver_flush_buffer(tty);
>> - }
>> if (L_ECHO(tty))
>> echo_char(c, tty);
>> - if (tty->pgrp)
>> - kill_pgrp(tty->pgrp, signal, 1);
>> + isig(signal, tty, 0);
>>
>
> My first reaction is that tty->pgrp must be null. Perhaps the patch
> could be simplified...
>
> if (tty->pgrp)
> kill_pgrp(tty->pgrp, signal, 1);
> + else
> + isig(signal, tty, 0);
>
>
> Thoughts?
>

isig has the same check, if it is NULL, isig won't deliver the signal
either:

if (tty->pgrp)
kill_pgrp(tty->pgrp, sig, 1);

--Edwin

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/