Re: [PATCH 21/24] kconfig: prefix hex values with 0x in .config

From: Ingo Molnar
Date: Tue Jul 01 2008 - 02:41:47 EST



* Sam Ravnborg <sam@xxxxxxxxxxxx> wrote:

> We could hit a situation where hex values
> are stored internally in kconfig without 0x prefix, so if we see
> one of these add 0x prefix when we write value to .config.
> The real fix is to make sure we always prefix hex
> values with 0x in kconfig.
>
> Signed-off-by: Sam Ravnborg <sam@xxxxxxxxxxxx>
> Cc: Roman Zippel <zippel@xxxxxxxxxxxxxx>
> ---
> arch/x86/boot/compressed/relocs.c | 2 +-
> scripts/kconfig/confdata.c | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/arch/x86/boot/compressed/relocs.c b/arch/x86/boot/compressed/relocs.c
> index edaadea..88d27f6 100644
> --- a/arch/x86/boot/compressed/relocs.c
> +++ b/arch/x86/boot/compressed/relocs.c
> @@ -244,7 +244,7 @@ static void read_ehdr(FILE *fp)
> static void read_shdrs(FILE *fp)
> {
> int i;
> - if (ehdr.e_shnum > MAX_SHDRS) {
> + if (1 || ehdr.e_shnum > MAX_SHDRS) {
> die("%d section headers supported: %d\n",
> ehdr.e_shnum, MAX_SHDRS);
> }

note: stale x86 change slipped into this patch, please do not commit it
to the kbuild tree. (i suspect it happened when you sent me the
MAX_SHDRS debug patch yesterday)

Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/