Re: [PATCH 3/3] softlockup: fix watchdog task wakeup frequency

From: Ingo Molnar
Date: Tue Jul 01 2008 - 02:12:32 EST



* Johannes Weiner <hannes@xxxxxxxxxxxx> wrote:

> Hi,
>
> Ingo Molnar <mingo@xxxxxxx> writes:
>
> > * Johannes Weiner <hannes@xxxxxxxxxxxx> wrote:
> >
> >> > + /*
> >> > + * Wake up the high-prio watchdog task twice per
> >> > + * threshold timespan.
> >> > + */
> >> > + if (now > touch_timestamp + softlockup_thresh/2)
> >> > wake_up_process(per_cpu(watchdog_task, this_cpu));
> >>
> >> That defeats patch 1/3 and I think it can be dropped (#1).
> >
> > applied this updated patch to tip/core/softlockup. #3 didnt apply -
> > could you send a delta patch against tip/core/softlockup please? You can
> > pick it up via:
> >
> > http://people.redhat.com/mingo/tip.git/README
> >
> > do:
> >
> > git-checkout -b core/softlockup tip/core/softlockup
> >
> > to check it out.
>
> Uhm, I see this patch is already in. Misunderstanding or did you fix
> it up yourself?

i applied and tested everything that would apply (modulo trivial
conflict resolution) - but not all of your patches applied so if there's
still anything missing please send a delta patch against this branch.
(or against tip/master, which too has all these changes included)

If it's "no further patch needed" that's fine - and if anything is
missing please resend that bit.

Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/