Re: [PATCH 7/7] Fix the case of jiffies wrapping in mm/pdflush.c

[OGAWA Hirofumi]

Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx> writes:

>> @@ -151,7 +151,7 @@ static int __pdflush(struct pdflush_work
>>  		if (nr_pdflush_threads <= MIN_PDFLUSH_THREADS)
>>  			continue;
>>  		pdf = list_entry(pdflush_list.prev, struct pdflush_work, list);
>> -		if (jiffies - pdf->when_i_went_to_sleep > 1 * HZ) {
>> +		if (time_after(jiffies, pdf->when_i_went_to_sleep + 1 * HZ)) {
>>  			/* Limit exit rate */
>>  			pdf->when_i_went_to_sleep = jiffies;
>>  			break;					/* exeunt */
>
> I don't think this actually "fixes" anything, does it?  The old code
> should be correct at runtime.

Um.. Yes. It seems I tested something wrong.

> I renamed the patch to "pdflush: use time_after() instead of open-coding it".

Thanks.
-- 
OGAWA Hirofumi <hirofumi@xxxxxxxxxxxxxxxxxx>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/