Re: [PATCH 1/13] EDAC i5100 new intel chipset driver

[Arthur Jones]

Hi Andi, ...

On Fri, Jun 27, 2008 at 10:07:21PM -0700, Andi Kleen wrote:
> dougthompson@xxxxxxxxxxxx writes:
> >
> > 2)  I have not yet tackled the de-interleaving of the
> > rank/controller address space into the physical address
> > space of the CPU.  There is nothing fundamentally missing,
> > it is just ending up to be a lot of code, and I'd rather
> > keep it separate for now, esp since it doesn't work yet...
> >
> > 3)  The code depends on a particular i5100 chip select
> > to DIMM mainboard chip select mapping.  This mapping
> > seems obvious to me in order to support dual and single
> > ranked memory, but it is not unique and DIMM labels
> > could be wrong on other mainboards.  There is no way
> > to query this mapping that I know of.
> 
> Since there's a non negligible probability that the output
> of this driver is completely misleading because of (2) and (3)
> and probably (4) too [reporting the wrong DIMMs etc.]
> would it be possible to add some flag to EDAC that
> warns the user that the output is not fully reliable?

The code properly presents all the right info
in 2).  All that is missing the actual memory
address -- which is not printed, but everything
that it does print comes straight from the chip,
so it should be right.  Also, for 4), the driver
won't load unless it's in the proper mode.

So, that leaves 3), which is indeed highly suspect.
Most (all?) EDAC drivers don't print a DIMM label
probably for this very reason.  Perhaps it is better
to just take out that bit of code and leave the DIMM
label blank?

> -Andi (who can just see people replacing the wrong DIMMs and
> then blaming Linux)

Yeah, I can see this happening...

Arthur

> -------------------------------------------------------------------------
> Check out the new SourceForge.net Marketplace.
> It's the best place to buy or sell services for
> just about anything Open Source.
> http://sourceforge.net/services/buy/index.php
> _______________________________________________
> bluesmoke-devel mailing list
> bluesmoke-devel@xxxxxxxxxxxxxxxxxxxxx
> https://lists.sourceforge.net/lists/listinfo/bluesmoke-devel
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/