Re: [PATCH 1/4] security: filesystem capabilities bugfix1

From: David Howells
Date: Mon Jun 30 2008 - 09:21:54 EST


Andrew G. Morgan <morgan@xxxxxxxxxx> wrote:

> +kernel_cap_t cap_set_effective(const kernel_cap_t pE_new)

Hmmm... kernel_cap_t is a structure that might not fit into a single register.
It occurs to me that you might be better off returing the old caps through a
pointer argument. It should still work, though.

The SElinux and syscalls LTP testscripts work okay for these patches when
ported to linux-next. The filecaps LTP testscript can't be used on Fedora 9
as the setcap command is used incorrectly.

Acked-by: David Howells <dhowells@xxxxxxxxxx>

David
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/